Song edit not alerting us of "wrong lyrics format" [solved]

›Forum›browse›Support›Song edit not alerting us of "wrong lyrics format" [solved]

Follow 1

Add topic

MCSMeister | 05-08-2016 12:57

I would have posted about this weeks ago, but I had falsely thought the issue was fixed. Doesn't seem like it

A while back on the Spelling errors thread, I posted this:

On a related note, I'm assuming the max characters per line was increased to 100? I swore it was 75 before. It's confusing, though, because if a line reaches 75 characters, it will still appear in the content check as "wrong lyrics format" without giving you a warning that the line is too long.

This may have something to do with this issue. It seems that right now, some songs will pop up as "wrong lyrics format" on the content check (aka one or more of the lines of lyrics is too long), except it gives me no alert that the line is too long.

In the past, it has always alerted me if a line is too long and wouldn't let me submit the song until I split the line into smaller lines. But now it's not. Thus, I have to guess which line is the culprit and shorten all of the remotely long lines instead of it telling me which one is long.

It seems that once you reach 100 characters, then it properly alerts you (I tested that out), but it seems that there's still a certain character limit under that that triggers the "wrong lyrics format" message in the content check.

Here's an example of a song I was able to submit just fine with no alerts, but gives this message in the content check.

2 comments

Ray | 29-09-2016 14:29

Bug fixed, the content checker should now give the correct info.

MCSMeister | 29-09-2016 15:37

Great! So what is the max amount of characters per line now, 75 or 100? Just want to test this out and make sure it warns me if I exceed the amount.

guest

POP OUT SAVE

$form.$set(f,{a:'ajax_comment_manage',pop:'in',content_type:'forumtopic',parent_id:'583125',follow:0},{noaskonclose:1});

//--------------------------------------------------------------------------------------------------
//  On save
//--------------------------------------------------------------------------------------------------

$events.$addFunction('click',1545420973,true,function(){
      //--------------------------------------------------------------------------------------------
      //  Find form element
      //--------------------------------------------------------------------------------------------
          var f=arguments[0].$t.closest('form');
      //--------------------------------------------------------------------------------------------
      //  Callback
      //--------------------------------------------------------------------------------------------
          var $callback = function(f,$c,$json) {
            if ($json.hasOwnProperty('mode') && $json.mode == 'popin') { // Error occured - popin version
              f.parent().html($json.body);
            }
            else {
              var $formrow = $('#id_1545492900').closest('div[data-form]'); // Find the wrapper of the form (div that holds the form)
              //------------------------------------------------------------------------------------
              //  Remove lightbox for popout or reset popin form
              //------------------------------------------------------------------------------------
                 if ($json.pop == 'out') {
                   lightbox_remove();
                 }
                 else {
                   $formrow.find('[data-b]').find('span').show().last().hide();
                   f.find('textarea[name=comment]').prop('disabled',false).val('');
                   f.find('input[name=vote]').val('');
                   f.find('.errors').remove(); // remove error box if present
                 }
              //------------------------------------------------------------------------------------
              //  Insert on bottom
              //------------------------------------------------------------------------------------
                  if ($json.content_type == 'forumtopic')
                    $('html, body') // html and body both needed for cross browser compatibility
                      .animate({ scrollTop:$formrow.last().offset().top - 200 }, 500)
                      .promise() // the promise-done deals with preventing a double call for browser that support both html and body
                      .done(function(){ 
                        $formrow.last().before($json.comment).prev().rowslide({effect:'open'});
                      });
              //------------------------------------------------------------------------------------
              //  Insert on top
              //------------------------------------------------------------------------------------
                  else $formrow.first().after($json.comment).next().rowslide({effect:'open'});
              }

return;
          };
      //--------------------------------------------------------------------------------------------
      //  Parse request
      //--------------------------------------------------------------------------------------------
          $http.$req({m:'POST',d:1,q:f.serialize(),b:$.proxy($callback,null,f)});
      //--------------------------------------------------------------------------------------------
      //  "After-click" styling
      //--------------------------------------------------------------------------------------------
          if (f.find('input[name=pop]').val() == 'in') {
            arguments[0].$t.parent().children().hide().last().show();
            f.find('textarea[name=comment]').prop('disabled',true); // do after $http.$req because serialize ignores disabled fields
          }
          else {
            lightbox_remove({keepdim:1});
            lightbox_prepare({});
          }

});
//--------------------------------------------------------------------------------------------------
//  Detach function (pop-out button and poll vote button) - prepare for "detach" submit
//--------------------------------------------------------------------------------------------------
    $events.$addFunction('click',1519156756,true,function(){
      var f = arguments[0].$t.closest('form');
      f.find('input[name=reload]').val(1);
      f.find('input[name=pop]').val('out');
      //if (arguments[0].$t.is('[data-vote]')) f.find('input[name=vote]').val(arguments[0].$t.attr('data-vote'));
      f.find('.errors').remove();
    });
    $events.$addFunction('click',1545858987,true,function(){ // Poll-vote button
      var f = $('#id_1545492900');
      f.find('input[name=vote]').val(arguments[0].$t.attr('data-vote'));
      $('#id_1545858923').trigger('click');
    });
//--------------------------------------------------------------------------------------------------
//  Reset popin form
//--------------------------------------------------------------------------------------------------
    $events.$addFunction('click',1545413833,true,function(){
      var f = arguments[0].$t.closest('form');
      f.find('input[name=reload]').val(0);
      f.find('input[name=pop]').val('in');
      f.find('input[name=vote]').val('');
      f.find('textarea[name=comment]').val('');
    });