Numerous things wrong with the Contribute button [solved]

›Forum›browse›Support›Numerous things wrong with the Contribute button [solved]

Follow 1

Add topic

MCSMeister | 29-04-2016 23:44

This might be something Ray is currently updating so it's wonky at the moment, but I still should post these anyway.

- The edit album button is gone
- Some artist pages (example) give the eternal loading circle when you press Add Song. Not all of them do, though.
- Content Check also gives the eternal loading circle
- Artist moderating seems to be broken entirely. Under the Contribute button, all of the instances of the artist's name are blank, and signing up for artist moderator also gives the eternal loading circle.

Apologies if this is something you're already fixing, Ray, and I'm just preaching to the choir. I just think it's important to point out these glitches regardless.

8 comments

roxcyn | 29-04-2016 23:53

When I tried the artist you mentioned, it let me into the add song form, Nicolas.

Ray | 29-04-2016 23:54

I shouldn't work late, messup overtime

fixed!

MCSMeister | 29-04-2016 23:54

Yup, it all works now, Scott. Thanks Ray, as always!

Ray | 29-04-2016 23:58

No thanks needed when I broke stuff myself. I'm a specialist breaker, you don't want me hanging around on your site

But thank you for the detailed description, that made me able to find the problem in a second.

MCSMeister | 30-04-2016 00:01

Hahaha, you're welcome. I try my best to report glitches ASAP if they persist.

Also, are there supposed to be white bars separating the different buttons on pages now? It's not a bad feature, but the lines look rather...thin. Thickening the lines would be more pleasing on the eyes from a design standpoint, I would think. Maybe it's just me

Ray | 30-04-2016 00:04

Yeah, good point. I'm not 100% happy with it myself yet. I think the color is too bright. Maybe thickening would make things more nice. Going to try that as well

PracticePractic | 30-04-2016 00:25

I'm not 100% happy with it myself yet. I think the color is too bright. Maybe thickening would make things more nice. Going to try that as well

And its keeping tabs of all the important things that many outside of the web design community would not even know existed is what makes this site sparkle and jump versus the other run of the mill cookie-cutter sites out there

(especially those who just steal/copy off other site's codes as a short cut!)

Ray | 30-04-2016 00:28

^^ very true

guest

POP OUT SAVE

$form.$set(f,{a:'ajax_comment_manage',pop:'in',content_type:'forumtopic',parent_id:'580522',follow:0},{noaskonclose:1});

//--------------------------------------------------------------------------------------------------
//  On save
//--------------------------------------------------------------------------------------------------

$events.$addFunction('click',1545420973,true,function(){
      //--------------------------------------------------------------------------------------------
      //  Find form element
      //--------------------------------------------------------------------------------------------
          var f=arguments[0].$t.closest('form');
      //--------------------------------------------------------------------------------------------
      //  Callback
      //--------------------------------------------------------------------------------------------
          var $callback = function(f,$c,$json) {
            if ($json.hasOwnProperty('mode') && $json.mode == 'popin') { // Error occured - popin version
              f.parent().html($json.body);
            }
            else {
              var $formrow = $('#id_1545492900').closest('div[data-form]'); // Find the wrapper of the form (div that holds the form)
              //------------------------------------------------------------------------------------
              //  Remove lightbox for popout or reset popin form
              //------------------------------------------------------------------------------------
                 if ($json.pop == 'out') {
                   lightbox_remove();
                 }
                 else {
                   $formrow.find('[data-b]').find('span').show().last().hide();
                   f.find('textarea[name=comment]').prop('disabled',false).val('');
                   f.find('input[name=vote]').val('');
                   f.find('.errors').remove(); // remove error box if present
                 }
              //------------------------------------------------------------------------------------
              //  Insert on bottom
              //------------------------------------------------------------------------------------
                  if ($json.content_type == 'forumtopic')
                    $('html, body') // html and body both needed for cross browser compatibility
                      .animate({ scrollTop:$formrow.last().offset().top - 200 }, 500)
                      .promise() // the promise-done deals with preventing a double call for browser that support both html and body
                      .done(function(){ 
                        $formrow.last().before($json.comment).prev().rowslide({effect:'open'});
                      });
              //------------------------------------------------------------------------------------
              //  Insert on top
              //------------------------------------------------------------------------------------
                  else $formrow.first().after($json.comment).next().rowslide({effect:'open'});
              }

return;
          };
      //--------------------------------------------------------------------------------------------
      //  Parse request
      //--------------------------------------------------------------------------------------------
          $http.$req({m:'POST',d:1,q:f.serialize(),b:$.proxy($callback,null,f)});
      //--------------------------------------------------------------------------------------------
      //  "After-click" styling
      //--------------------------------------------------------------------------------------------
          if (f.find('input[name=pop]').val() == 'in') {
            arguments[0].$t.parent().children().hide().last().show();
            f.find('textarea[name=comment]').prop('disabled',true); // do after $http.$req because serialize ignores disabled fields
          }
          else {
            lightbox_remove({keepdim:1});
            lightbox_prepare({});
          }

});
//--------------------------------------------------------------------------------------------------
//  Detach function (pop-out button and poll vote button) - prepare for "detach" submit
//--------------------------------------------------------------------------------------------------
    $events.$addFunction('click',1519156756,true,function(){
      var f = arguments[0].$t.closest('form');
      f.find('input[name=reload]').val(1);
      f.find('input[name=pop]').val('out');
      //if (arguments[0].$t.is('[data-vote]')) f.find('input[name=vote]').val(arguments[0].$t.attr('data-vote'));
      f.find('.errors').remove();
    });
    $events.$addFunction('click',1545858987,true,function(){ // Poll-vote button
      var f = $('#id_1545492900');
      f.find('input[name=vote]').val(arguments[0].$t.attr('data-vote'));
      $('#id_1545858923').trigger('click');
    });
//--------------------------------------------------------------------------------------------------
//  Reset popin form
//--------------------------------------------------------------------------------------------------
    $events.$addFunction('click',1545413833,true,function(){
      var f = arguments[0].$t.closest('form');
      f.find('input[name=reload]').val(0);
      f.find('input[name=pop]').val('in');
      f.find('input[name=vote]').val('');
      f.find('textarea[name=comment]').val('');
    });