Content check issues [solved]

›Forum›browse›Support›Content check issues [solved]

Follow 1

Add topic

MCSMeister | 18-04-2016 10:05

I've been noticing two new errors regarding LSI's content check:

1) The songs listed as "missing genre" seem to always be incomplete. It seems to be arbitrary which ones are listed, but it only lists a few that are missing genre instead of all of them. All of the other "missing"s seem to have complete lists, it's only the "missing genre" that's the issue.

2) Regarding duplicate songs: when there is a duplicate song, it says this:

Duplicate song. Make sure every song is listed only once. Find all songs with this title, find the "best" one and remove the others.

There's a link where I bolded the text, where it says "Find". However, when you click this link, it takes you to an empty search instead of searching all songs of this title.

3 comments

Ray | 22-04-2016 11:41

Fixed

MCSMeister | 30-04-2016 01:49

I know this is already solved, but here's another issue that's always bothered me about content check and has been around since I've been here:

If a song only appears on a compilation or soundtrack, the song will be marked as "missing album" in the content check. Perhaps you can fix this, because there's many songs that are soundtrack-only and never actually appear on an album of the artist's.

Ray | 01-08-2016 12:10

You're right. But making the suggested changes will also have a negative side effect: popular songs that appear on compilation albums will not appear as "missing album" anymore (when not linked to an album of the artist itself), while exactly these albums + links we need to have.

I prefer to keep the situation as it is, unless we have a best-of-both-worlds solution

guest

POP OUT SAVE

$form.$set(f,{a:'ajax_comment_manage',pop:'in',content_type:'forumtopic',parent_id:'580138',follow:0},{noaskonclose:1});

//--------------------------------------------------------------------------------------------------
//  On save
//--------------------------------------------------------------------------------------------------

$events.$addFunction('click',1545420973,true,function(){
      //--------------------------------------------------------------------------------------------
      //  Find form element
      //--------------------------------------------------------------------------------------------
          var f=arguments[0].$t.closest('form');
      //--------------------------------------------------------------------------------------------
      //  Callback
      //--------------------------------------------------------------------------------------------
          var $callback = function(f,$c,$json) {
            if ($json.hasOwnProperty('mode') && $json.mode == 'popin') { // Error occured - popin version
              f.parent().html($json.body);
            }
            else {
              var $formrow = $('#id_1545492900').closest('div[data-form]'); // Find the wrapper of the form (div that holds the form)
              //------------------------------------------------------------------------------------
              //  Remove lightbox for popout or reset popin form
              //------------------------------------------------------------------------------------
                 if ($json.pop == 'out') {
                   lightbox_remove();
                 }
                 else {
                   $formrow.find('[data-b]').find('span').show().last().hide();
                   f.find('textarea[name=comment]').prop('disabled',false).val('');
                   f.find('input[name=vote]').val('');
                   f.find('.errors').remove(); // remove error box if present
                 }
              //------------------------------------------------------------------------------------
              //  Insert on bottom
              //------------------------------------------------------------------------------------
                  if ($json.content_type == 'forumtopic')
                    $('html, body') // html and body both needed for cross browser compatibility
                      .animate({ scrollTop:$formrow.last().offset().top - 200 }, 500)
                      .promise() // the promise-done deals with preventing a double call for browser that support both html and body
                      .done(function(){ 
                        $formrow.last().before($json.comment).prev().rowslide({effect:'open'});
                      });
              //------------------------------------------------------------------------------------
              //  Insert on top
              //------------------------------------------------------------------------------------
                  else $formrow.first().after($json.comment).next().rowslide({effect:'open'});
              }

return;
          };
      //--------------------------------------------------------------------------------------------
      //  Parse request
      //--------------------------------------------------------------------------------------------
          $http.$req({m:'POST',d:1,q:f.serialize(),b:$.proxy($callback,null,f)});
      //--------------------------------------------------------------------------------------------
      //  "After-click" styling
      //--------------------------------------------------------------------------------------------
          if (f.find('input[name=pop]').val() == 'in') {
            arguments[0].$t.parent().children().hide().last().show();
            f.find('textarea[name=comment]').prop('disabled',true); // do after $http.$req because serialize ignores disabled fields
          }
          else {
            lightbox_remove({keepdim:1});
            lightbox_prepare({});
          }

});
//--------------------------------------------------------------------------------------------------
//  Detach function (pop-out button and poll vote button) - prepare for "detach" submit
//--------------------------------------------------------------------------------------------------
    $events.$addFunction('click',1519156756,true,function(){
      var f = arguments[0].$t.closest('form');
      f.find('input[name=reload]').val(1);
      f.find('input[name=pop]').val('out');
      //if (arguments[0].$t.is('[data-vote]')) f.find('input[name=vote]').val(arguments[0].$t.attr('data-vote'));
      f.find('.errors').remove();
    });
    $events.$addFunction('click',1545858987,true,function(){ // Poll-vote button
      var f = $('#id_1545492900');
      f.find('input[name=vote]').val(arguments[0].$t.attr('data-vote'));
      $('#id_1545858923').trigger('click');
    });
//--------------------------------------------------------------------------------------------------
//  Reset popin form
//--------------------------------------------------------------------------------------------------
    $events.$addFunction('click',1545413833,true,function(){
      var f = arguments[0].$t.closest('form');
      f.find('input[name=reload]').val(0);
      f.find('input[name=pop]').val('in');
      f.find('input[name=vote]').val('');
      f.find('textarea[name=comment]').val('');
    });