Submitting reviews with no corrections [solved]

›Forum›browse›Support›Submitting reviews with no corrections [solved]

Follow 3

Add topic

PinkFloyd | 28-05-2015 14:30

This has been an issue for a long time. Basically members or guests can edit or request lyrics or albums without actually changing anything. Example here. This occurs often, I see it happen daily. Not too big of a deal, I just select "no, the lyrics are incomplete," and move on.

But whenever I try, by mistake, or on purpose, to test the issue, the form doesn't allow me to submit without changes. Example here.

Are guests/members maybe actually making corrections but they are just not coming through? Or how are they able to send nothing?

18 comments

Ray | 28-05-2015 17:20

Interesting

At least something is not working, fix team is on its way.

Ray | 16-06-2015 21:34

I've doing some logging, but didn't find anything useful yet. Can you tell me if the issue occurs for both songs and albums? I see you mentioned both, but just to be sure

Also, are these submissions coming from member, guests or Snap?

PinkFloyd | 17-06-2015 14:59

I've noticed it on both songs and albums and it's only from guests.

roxcyn | 17-06-2015 20:59

I get the same error. I decided to make a change and then place it back as the original and push "save", but I get the same error as PinnkFloyd.

Joeyy | 22-06-2015 00:11

I didn't see this until recently. This problem annoys the absolute becheesus out of me. Whole songs with no corrections. Or songs with some lines marked as corrections that are corrections, and other lines marked as corrections that are the exact same as the current lines!

It has been driving me mad for years. I end up staring at the non-corrections for ages, going back and forth, trying to see if there really is something to correct that I'm just not seeing. It's a pain in the butt.

Joeyy | 22-06-2015 00:13

OK, you can't see the lines in red very well (zooming in helps somewhat), but they (the circled ones) are the same.

roxcyn | 22-06-2015 07:40

That's weird, Joeyy. I haven't gotten one of those yet where they made no change but LSI says it has (with the red/yellow highlighting). I did zoom up and I can tell what you mean--no changes at all!

vrose9 | 22-06-2015 12:41

@ Joeyy I just noticed your comment above where you said:

Joeyy | 22-06-2015 16:23

Hi, vrose9. I'm not sure what you mean by that, but I was just using your submitted corrections as an example here - it's not your fault.

vrose9 | 23-06-2015 09:00

Hi Joeyy.... I didn't get to finish what I was writing above, and I couldn't delete it because I couldn't find anywhere where it allows a comment to be deleted. I wasn't actually finished with my comment, which is why you don't know what I meant by what I said above....

vrose9 | 23-06-2015 10:19

However, Joeyy, I did get your message about the site glitch and understand, so thank you for letting me know. I feel so much better! LOL!

PinkFloyd | 23-06-2015 19:10

Ray – I don't know why I didn't think to try this before. But I signed out, and attempted to "correct" a song. I found a song with no moderator and made no changes to it, typed in the anti-spam code and sent it in. And it was accepted. It should not have accepted it. It should have given me "No changes have been made, ... whatever, whatever."

I made a song "correction" and also an album "correction".

It accepted both. Again, I think this is only happening with guests. I'm not sure about Joey's problem.

Ray | 23-06-2015 21:41

I like this pitbull attitude to kill this bug ... rrRRRooAAARrrrr

ok, looking into it now ...

Ray | 23-06-2015 22:04

Found and fixed it

Pitbull attitude paid off, nice work!

Joeyy | 23-06-2015 22:05

So no more corrections that aren't corrections?

Ray | 23-06-2015 22:09

yup

Ray | 23-06-2015 22:11

... unless, of course, where there are more similar bugs in the system.

* end of disclaimer *

roxcyn | 24-06-2015 06:55

* offtopic :
Hi vrose9! When you post, you are right--you can't delete it unless a moderator on the forum does it. You can edit your post for 15 minutes. Click the little nut (upper right in your post by the like) and you the edit option appears for 15 minutes

guest

POP OUT SAVE

$form.$set(f,{a:'ajax_comment_manage',pop:'in',content_type:'forumtopic',parent_id:'565454',follow:0},{noaskonclose:1});

//--------------------------------------------------------------------------------------------------
//  On save
//--------------------------------------------------------------------------------------------------

$events.$addFunction('click',1545420973,true,function(){
      //--------------------------------------------------------------------------------------------
      //  Find form element
      //--------------------------------------------------------------------------------------------
          var f=arguments[0].$t.closest('form');
      //--------------------------------------------------------------------------------------------
      //  Callback
      //--------------------------------------------------------------------------------------------
          var $callback = function(f,$c,$json) {
            if ($json.hasOwnProperty('mode') && $json.mode == 'popin') { // Error occured - popin version
              f.parent().html($json.body);
            }
            else {
              var $formrow = $('#id_1545492900').closest('div[data-form]'); // Find the wrapper of the form (div that holds the form)
              //------------------------------------------------------------------------------------
              //  Remove lightbox for popout or reset popin form
              //------------------------------------------------------------------------------------
                 if ($json.pop == 'out') {
                   lightbox_remove();
                 }
                 else {
                   $formrow.find('[data-b]').find('span').show().last().hide();
                   f.find('textarea[name=comment]').prop('disabled',false).val('');
                   f.find('input[name=vote]').val('');
                   f.find('.errors').remove(); // remove error box if present
                 }
              //------------------------------------------------------------------------------------
              //  Insert on bottom
              //------------------------------------------------------------------------------------
                  if ($json.content_type == 'forumtopic')
                    $('html, body') // html and body both needed for cross browser compatibility
                      .animate({ scrollTop:$formrow.last().offset().top - 200 }, 500)
                      .promise() // the promise-done deals with preventing a double call for browser that support both html and body
                      .done(function(){ 
                        $formrow.last().before($json.comment).prev().rowslide({effect:'open'});
                      });
              //------------------------------------------------------------------------------------
              //  Insert on top
              //------------------------------------------------------------------------------------
                  else $formrow.first().after($json.comment).next().rowslide({effect:'open'});
              }

return;
          };
      //--------------------------------------------------------------------------------------------
      //  Parse request
      //--------------------------------------------------------------------------------------------
          $http.$req({m:'POST',d:1,q:f.serialize(),b:$.proxy($callback,null,f)});
      //--------------------------------------------------------------------------------------------
      //  "After-click" styling
      //--------------------------------------------------------------------------------------------
          if (f.find('input[name=pop]').val() == 'in') {
            arguments[0].$t.parent().children().hide().last().show();
            f.find('textarea[name=comment]').prop('disabled',true); // do after $http.$req because serialize ignores disabled fields
          }
          else {
            lightbox_remove({keepdim:1});
            lightbox_prepare({});
          }

});
//--------------------------------------------------------------------------------------------------
//  Detach function (pop-out button and poll vote button) - prepare for "detach" submit
//--------------------------------------------------------------------------------------------------
    $events.$addFunction('click',1519156756,true,function(){
      var f = arguments[0].$t.closest('form');
      f.find('input[name=reload]').val(1);
      f.find('input[name=pop]').val('out');
      //if (arguments[0].$t.is('[data-vote]')) f.find('input[name=vote]').val(arguments[0].$t.attr('data-vote'));
      f.find('.errors').remove();
    });
    $events.$addFunction('click',1545858987,true,function(){ // Poll-vote button
      var f = $('#id_1545492900');
      f.find('input[name=vote]').val(arguments[0].$t.attr('data-vote'));
      $('#id_1545858923').trigger('click');
    });
//--------------------------------------------------------------------------------------------------
//  Reset popin form
//--------------------------------------------------------------------------------------------------
    $events.$addFunction('click',1545413833,true,function(){
      var f = arguments[0].$t.closest('form');
      f.find('input[name=reload]').val(0);
      f.find('input[name=pop]').val('in');
      f.find('input[name=vote]').val('');
      f.find('textarea[name=comment]').val('');
    });